Hmm, obviously we're not getting the story of his good points, but him slapping you is a big standout negative. I would never *ever* lay a hand on my girlfriend in anger, and that is not a good sign at all.

Sacrificing is something that we all do for love, but it seems that your sacrifices are going mostly unappreciated. Unless he truly appreciates all the things you're doing for him, there is a problem that needs to at least be talked about. And if he just gets mad and won't talk through problems, well I think you should have your answer about where your relationship is going from that.

Good luck